Skip to content

Conversation

RedbackThomson
Copy link
Contributor

Fixes aws-controllers-k8s/community#1361

Description of changes:
Code-generator currently compares the subdirectories in the API output directory (apis/) to determine the latest K8s version of the CRDs. The information about which API versions should be generated, and their status (available, deprecated, etc.), already exist in the metadata.yaml file. This pull request updates the source of truth for the code-generator to be the metadata.yaml file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from brycahta and jaypipes June 24, 2022 18:58
@vijtrip2
Copy link
Contributor

/test s3-olm-test

@vijtrip2
Copy link
Contributor

Neat!
/approve

@ack-bot
Copy link
Collaborator

ack-bot commented Jun 24, 2022

@RedbackThomson: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
dynamodb-controller-test 220ed44 link /test dynamodb-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you @RedbackThomson

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 208b1e1 into aws-controllers-k8s:main Jun 25, 2022
@RedbackThomson RedbackThomson deleted the mkdir-version branch June 28, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code-generator requires apis/v1alpha1 directory
4 participants