Use latest from sdk create/update for rm.onError() #344
Conversation
|
Kind note to reviewer: Please wait for all the controller tests to pass before merging. Since controller tests are optional, lgtm command will skip them and merge right away. |
|
/lgtm |
|
@brucegucode: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brucegucode, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…8s#344) Issue #, if available: aws-controllers-k8s/community#1336 Description of changes: * After the sdkCreate/sdkUpdate call, the resource manager was still using the latest from ReadOne call when invoking `rm.onError` method * Instead it should use the resource returned from sdkCreate and sdkUpdate call By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#1336
Description of changes:
rm.onErrormethodBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.