reset resolved references if any reference cannot be resolved #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vijtrip2: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jaypipes
approved these changes
Jun 15, 2022
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RedbackThomson
pushed a commit
to RedbackThomson/ack-code-generator
that referenced
this pull request
Jun 21, 2022
…ntrollers-k8s#342) Issue #, if available: aws-controllers-k8s/community#1342 Description of changes: TL;DR: * This change makes sure that partially resolved references do not get added to concrete resource inside `rm.ResolveReferences` unless all the references can be successfully resolved. Detailed Version * Inside `rm.ResolveReferences`, all the references are resolved sequentially and whenever any reference resolution fails it short circuits other reference resolutions. * However the successfully resolved references, before the first fail one, get updated inside the concrete resource(ko). * An error from `rm.ResolveReferences` causes the `HandleReconcilerError` to call PatchMetadataAndSpec, and the partial resolved references get persisted inside etcd. * When the resolved references get persisted inside etcd, they cause the validation failure on next reconciler loop that both Ref and Id field cannot be present at the same time. * The resolved references do not get persisted in etcd when reference resolution is successful because the desired object in memory get replaced by resolvedRefDesired and does not present resolved references as candidate for patch merge. During the failure desired object does not get replaced by resolvedRefDesired and presents the resolved references as patch candidate. * We cannot update desired with resolvedRefDesired in an error case because then we will lose diff of ACK conditions added by `rm.ResolveReferences`. * Ignoring the partially resolved reference during an error in `rm.ResolveReferences` is a clean and simple solution. * I tested this by running apigatewayv2 tests locally. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws-controllers-k8s/community#1342
Description of changes:
TL;DR:
rm.ResolveReferencesunless all the references can be successfully resolved.Detailed Version
rm.ResolveReferences, all the references are resolved sequentially and whenever any reference resolution fails it short circuits other reference resolutions.rm.ResolveReferencescauses theHandleReconcilerErrorto call PatchMetadataAndSpec, and the partial resolved references get persisted inside etcd.rm.ResolveReferences.rm.ResolveReferencesis a clean and simple solution.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.