Add a new generator config to append a Synced printer column
#329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all ACK kubernetes resources have a synced condition status, we need a way to instruct the code generator to generate kubebuilder marker comments that will append the SYNCED field the kubectl get response. This patch extends Resource.PrintConfig to allow configuring the ack-generate to generate such marker comments.
RedbackThomson
approved these changes
Apr 26, 2022
jaypipes
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Yeah, this is cool for now. I think maybe we should just do AGE and SYNCED always for all resources, though, and not need to be configurable as @RedbackThomson alluded to. But, for now, all good.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: aws-controllers-k8s/community#1281
Description:
Since all ACK kubernetes resources have a synced condition status,
we need a way to instruct the code generator to generate kubebuilder
marker comments that will append the SYNCED field the
kubectl getresponse.
This patch extends Resource.PrintConfig to allow configuring the
ack-generate to generate such marker comments.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.