Add initialisms contained within ACM PCA #322
Conversation
| {"Ec2", "EC2", "ec2", nil}, | ||
| {"Ecr", "ECR", "ecr", nil}, | ||
| // Prevent "Edit" from becoming "EDIt" | ||
| {"Edi", "EDI", "edi", regexp.MustCompile("Edi(?!t)", regexp.None)}, |
There was a problem hiding this comment.
Mind adding a quick unit test that verifies this one?
There was a problem hiding this comment.
Added! And sorted all tests because their ordering was annoying me
| {"EdiPartyName", "EDIPartyName", "ediPartyName", "edi_party_name"}, | ||
| {"Editable", "Editable", "editable", "editable"}, |
There was a problem hiding this comment.
My new additions
|
FYI I searched through all |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Add initialisms found within the ACM PCA types
CNAME,CRL,CPS,CSR,EDI,OCSP,RFCBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.