Skip to content

Remove hardcoded version in Makefile #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Remove hardcoded version in Makefile #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18dc67
Update version to `v0.18.2`
Mar 30, 2022
dcb45ca
Remove version check tied to runtime
Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/version-check.yaml
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ GO111MODULE=on
AWS_SERVICE=$(shell echo $(SERVICE) | tr '[:upper:]' '[:lower:]')

# Build ldflags
VERSION ?= "v0.18.1"
VERSION ?= $(shell git describe --tags --always --dirty)
GITCOMMIT=$(shell git rev-parse HEAD)
BUILDDATE=$(shell date -u +'%Y-%m-%dT%H:%M:%SZ')
IMPORT_PATH=github.com/aws-controllers-k8s/code-generator
Expand Down Expand Up @@ -52,9 +52,6 @@ local-build-controller-image: export LOCAL_MODULES = true
local-build-controller-image: ## Build container image for SERVICE allowing local modules
@./scripts/build-controller-image.sh $(AWS_SERVICE)

check-versions: ## Checks the code-generator version matches the runtime dependency version
@./scripts/check-versions.sh $(VERSION)

test: ## Run code tests
go test ${GO_CMD_FLAGS} ./...

Expand Down
33 changes: 0 additions & 33 deletions scripts/check-versions.sh
View file
Open in desktop

This file was deleted.