Skip to content

Conversation

vijtrip2
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#960

Description of changes:

  • Fix broken link for contributor docs
  • Use code-generator as source of truth for additional controller files

Tested locally by generating dynamodb controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @vijtrip2 :)

@jaypipes
Copy link
Collaborator

/lgtm

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 21, 2021

@jaypipes: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vijtrip2 vijtrip2 merged commit 386373b into aws-controllers-k8s:main Sep 21, 2021
@vijtrip2 vijtrip2 deleted the doc-link-fix branch September 21, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants