Skip to content

Conversation

brycahta
Copy link
Contributor

Issue #, if available: #922

Description of changes:

  • Refactor setSDKReadMany:
    • use FindPluralizedIdentifiersInShape helpers to simplify logic
  • Refactor setResourceForScalar:
    • Remove unused params
    • Add targetVar param to be the variable's fully-qualified name (i.e. fieldPath+varName r.ko.Spec.CacheClusterID)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from a-hilaly and vijtrip2 August 31, 2021 21:14
@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 31, 2021

Hi @brycahta. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brycahta brycahta changed the title Refactor *setSDKReadMany* and *setResourceForScalar* Refactor setSDKReadMany and setResourceForScalar Aug 31, 2021
@brycahta
Copy link
Contributor Author

/ok-to-test

@ack-bot
Copy link
Collaborator

ack-bot commented Aug 31, 2021

@brycahta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent cleanup, @brycahta, thank you!

@a-hilaly
Copy link
Member

a-hilaly commented Sep 1, 2021

/ok-to-test

@ack-bot ack-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2021
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vijtrip2
Copy link
Contributor

vijtrip2 commented Sep 2, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta, jaypipes, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit d20cb4f into aws-controllers-k8s:main Sep 2, 2021
@brycahta brycahta deleted the set-resource-refactor branch September 2, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants