use latest tag before non-release version #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `build-controller-release.sh` script to check for the latest Git tag on the target service controller repository before defaulting the RELEASE_VERSION to `v0.0.0-non-release-version`. This allows developers to regenerate their service controllers with new ACK runtimes without overwriting the static manifests' image versions from the latest published Git tag to `v0.0.0-non-release-version`. For service controllers that have yet to release any images, the `v0.0.0-non-release-version` continues to be used. Before this patch: ``` [jaypipes@thelio code-generator]$ make build-controller SERVICE=rds building ack-generate ... ok. ==== building rds-controller ==== Copying common custom resource definitions into rds Building Kubernetes API objects for rds Generating deepcopy code for rds Generating custom resource definitions for rds Building service controller for rds Generating RBAC manifests for rds Running gofmt against generated code for rds ==== building rds-controller release artifacts ==== Building release artifacts for rds-v0.0.0-non-release-version Generating common custom resource definitions Generating custom resource definitions for rds Generating RBAC manifests for rds ``` After this patch: ``` [jaypipes@thelio code-generator]$ make build-controller SERVICE=rds building ack-generate ... ok. ==== building rds-controller ==== Copying common custom resource definitions into rds Building Kubernetes API objects for rds Generating deepcopy code for rds Generating custom resource definitions for rds Building service controller for rds Generating RBAC manifests for rds Running gofmt against generated code for rds ==== building rds-controller release artifacts ==== Building release artifacts for rds-v0.0.4 Generating common custom resource definitions Generating custom resource definitions for rds Generating RBAC manifests for rds ``` Note that at this time, the RDS controller's latest published image is `v0.0.4`. Issue #912
|
/lgtm |
|
/lgtm cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
build-controller-release.shscript to check for the latestGit tag on the target service controller repository before defaulting
the RELEASE_VERSION to
v0.0.0-non-release-version. This allowsdevelopers to regenerate their service controllers with new ACK runtimes
without overwriting the static manifests' image versions from the latest
published Git tag to
v0.0.0-non-release-version. For servicecontrollers that have yet to release any images, the
v0.0.0-non-release-versioncontinues to be used.Before this patch:
After this patch:
Note that at this time, the RDS controller's latest published image is
v0.0.4.Issue aws-controllers-k8s/community#912
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.