use reflect to compare map/slice struct #157
Conversation
The `pkg/generate/code.CompareResource` function did not have a docstring indicating what the expected output Go code is. Added it and removed some extra blank newlines that were being injected into the output code erroneously.
Although it's not what I wanted and isn't the most efficient thing we could do, I'm implementing the slice of struct and map of struct comparisons using `reflect.DeepEqual`. Long-term, I'd like to enable our generator-config CompareConfig for nested struct fields, and to do that we cannot use `reflect.DeepEqual`, however for the time-being, since slice and map of struct is a hole in our delta logic, I'm pushing up this workaround.
|
Worth noting that I'm happy with this call for now. Functionality >> Performance with delta right now. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, exactly. And that was a bridge too far for me to implement at this juncture... thus, this hack :) |
5 participants
Although it's not what I wanted and isn't the most efficient thing we
could do, I'm implementing the slice of struct and map of struct
comparisons using
reflect.DeepEqual. Long-term, I'd like to enable ourgenerator-config CompareConfig for nested struct fields, and to do that
we cannot use
reflect.DeepEqual, however for the time-being, sinceslice and map of struct is a hole in our delta logic, I'm pushing up
this workaround.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.