Remove loops from GetWrapperOutputShape #145
Conversation
I believe two loops were left over from refactoring: * One loop over fieldPathParts have been replaced with recursion. The current loop will only execute the first element, so we can remove the loop. * Another loop over map keys, but we can simply use a map lookup instead for a bit better performance There is already a unit test for this code. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
Hi @chlunde. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-bot
added
the
needs-ok-to-test
|
/ok-to-test |
ack-bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, chlunde, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
I believe two loops were left over from refactoring:
One loop over fieldPathParts have been replaced with recursion. The
current loop will only execute the first element, so we can remove the
loop.
Another loop over map keys, but we can simply use a map lookup
instead for a bit better performance
There is already a unit test for this code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.