release script and helm bug fixes

[surajkota]

• cluster role and role binding name mismatch
• update controller image location to official public repository

Tested by creating sagemaker controller

Thanks @RedbackThomson for helping out

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[RedbackThomson]

For reference,

code-generator/templates/helm/templates/cluster-role-binding.yaml

Line 8 in 24d2344

name: {{ include "app.name" . }}

was no longer matching https://github.com/aws-controllers-k8s/sagemaker-controller/blob/f5f5e2bfa7756432ae350c3383349ebb47252829/helm/templates/cluster-role-controller.yaml#L7 after we changed the chart name from ack-sagemaker-controller to sagemaker-chart. This PR will hardcode the ClusterRole name to ack-<service>-controller, which matches

code-generator/scripts/build-controller-release.sh

Line 136 in 24d2344

K8S_RBAC_ROLE_NAME=${K8S_RBAC_ROLE_NAME:-"ack-$SERVICE-controller"}

.

[RedbackThomson]

Thanks @surajkota !
/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, surajkota

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[surajkota]

for reference
cluster role binding name was set to {{ include "app.name" . }} which got changed from ack-$service-controller to $service-charts but controller-gen which generated the cluster-role got the role name as ack-$service-controller from here https://github.com/aws-controllers-k8s/code-generator/blob/main/scripts/build-controller-release.sh#L135