Expose SetSDKForStruct and SetResourceForStruct in templates
#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedbackThomson
changed the title
SetSDKForStruct in templatesSetSDKForStruct and SetResourceForStruct in templates
|
/approve |
jaypipes
requested changes
Aug 2, 2021
| type templateCRDVars struct { | ||
| templateset.MetaVars | ||
| CRD *ackmodel.CRD | ||
| SDKAPI *ackmodel.SDKAPI |
There was a problem hiding this comment.
You might consider adding this to the "root" templateset.MetaVars at some point in the future.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
pushed a commit
to aws-controllers-k8s/s3-controller
that referenced
this pull request
Aug 2, 2021
Adds custom hooks to detect changes to the `Logging` spec field and optionally calls the `PutBucketLogging` SDK method. Currently errors are not populated into terminal conditions, and updates are not supported. Uses aws-controllers-k8s/code-generator#139 and aws-controllers-k8s/code-generator#140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Makes
setSDKForStructandsetResourceForStructpublic, so that they are accessible for other parts of the generator. ExposesSetSDKForStructasGoCodeSetSDKForStructandSetResourceForStructasGoCodeSetResourceForStructin the generator, and includesSDKAPIas a template variable to allow querying of API shapes to use with parameters in the new template methods.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.