Add a new sort option for kubebuilder:printcolumns marker comments
#124
Conversation
This patch adds a new option `Index` for print column configuration. Setting an index for a field and `resource.print.sortBy` to `index` will intruct the code generator to sort the `kubebuilder:printcolumns` by the `Index` value.
| case "index": | ||
| return func(a, b *PrinterColumn) bool { | ||
| return a.Index < b.Index | ||
| } |
There was a problem hiding this comment.
Should this be the first case in the switch? Sorting by index should be preferred over any other?
There was a problem hiding this comment.
I don't how moving this case could change the default/preferred value. sortByField will have one of the values.
There was a problem hiding this comment.
Did you mean moving it to the default case? or maybe somehow set a default for $resource.print.sortBy ?
There was a problem hiding this comment.
Oh no I totally misread this method. Sorry
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ws-controllers-k8s#124) Issue N/A This patch adds a new option `Index` for print column configuration. Setting an index for a field and `resource.print.sortBy` to `index` will intruct the code generator to sort the `kubebuilder:printcolumns` by the `Index` value. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
3 participants
Issue N/A
This patch adds a new option
Indexfor print column configuration.Setting an index for a field and
resource.print.sortBytoindexwillintruct the code generator to sort the
kubebuilder:printcolumnsby theIndexvalue.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.