Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkg/generate/code/set_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -922,21 +922,25 @@ func SetResourceIdentifiers(
continue

}
// Check that the field has potentially been renamed
renamedName, _ := r.InputFieldRename(
op.Name, memberName,
)

isPrimaryIdentifier := memberName == primaryIdentifier
cleanMemberNames := names.New(memberName)
cleanMemberNames := names.New(renamedName)
cleanMemberName := cleanMemberNames.Camel

memberPath := ""
_, inSpec := r.SpecFields[memberName]
_, inStatus := r.StatusFields[memberName]
_, inSpec := r.SpecFields[renamedName]
_, inStatus := r.StatusFields[renamedName]
switch {
case inSpec:
memberPath = cfg.PrefixConfig.SpecField
case inStatus:
memberPath = cfg.PrefixConfig.StatusField
case isPrimaryIdentifier:
panic("Primary identifier field '" + memberName + "' cannot be found in either spec or status.")
panic("Primary identifier field '" + memberName + "' in operation '" + op.Name + "' cannot be found in either spec or status.")
default:
continue
}
Expand Down
24 changes: 24 additions & 0 deletions pkg/generate/code/set_resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2690,6 +2690,30 @@ func TestSetResource_RDS_DBInstances_SetResourceIdentifiers(t *testing.T) {
)
}

func TestSetResource_RDS_DBSubnetGroup_SetResourceIdentifiers(t *testing.T) {
assert := assert.New(t)
require := require.New(t)

g := testutil.NewGeneratorForService(t, "rds")

crd := testutil.GetCRDByName(t, g, "DBSubnetGroup")
require.NotNil(crd)

// In our testdata generator.yaml file, we've renamed the original
// DBSubnetGroupName to just Name...
expected := `
if identifier.NameOrID == "" {
return ackerrors.MissingNameIdentifier
}
r.ko.Spec.Name = &identifier.NameOrID

`
assert.Equal(
expected,
code.SetResourceIdentifiers(crd.Config(), crd, "identifier", "r.ko", 1),
)
}

func TestSetResource_APIGWV2_ApiMapping_SetResourceIdentifiers(t *testing.T) {
assert := assert.New(t)
require := require.New(t)
Expand Down