Skip to content

Conversation

kumargauravsharma
Copy link
Contributor

Issue #, if available:
Code generator fails when custom implementation is provided for create scenario
Steps to reproduce:

  1. Run make build-ack-generate && make build-controller SERVICE=$SERVICE
  2. Observe:

    /Users/kumargsh/ws/github_ws/go/src/github.com/aws-controllers-k8s/elasticache-controller/pkg/resource/snapshot/sdk.go:311:17: expected ';', found created
    Error: not all generators ran successfully

  3. Corresponding sdk.go code:

    exit := rlog.Trace("rm.sdkCreate")
    defer exit(err)created, err = rm.CustomCreateSnapshot(ctx, desired)
    if created != nil || err != nil {
    return created, err
    }

Observe, missing newline after defer exit(err)

Description of changes:
Updated the template.

Testing

  • make test passed.
  • ElastiCache service controller gets generated fine.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested a review from vijtrip2 June 22, 2021 09:45
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@a-hilaly
Copy link
Member

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, kumargauravsharma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 38e309d into aws-controllers-k8s:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants