Add Trail CRD
#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need rebase after #2 /hold |
|
Need aws-controllers-k8s/test-infra#209 merge |
jaypipes
suggested changes
May 19, 2022
|
/test all |
vijtrip2
reviewed
May 23, 2022
a-hilaly
force-pushed
the
trail-crd
branch
4 times, most recently
from
2dc934d to
a20591d
Compare
RedbackThomson
suggested changes
May 24, 2022
a-hilaly
force-pushed
the
trail-crd
branch
2 times, most recently
from
237653c to
45a3c88
Compare
|
/hold |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
trail-crd
branch
6 times, most recently
from
1f0674b to
12e37bc
Compare
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
|
@vijtrip2 @jaypipes @RedbackThomson addressed all the comments above and added tests for update operations. PTAL |
RedbackThomson
suggested changes
May 25, 2022
Description of changes: Creates the `Trail` CRD and adds basic smoke tests for trails
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a-hilaly
added a commit
to a-hilaly/ack-cloudtrail-controller
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Creates the
TrailCRD and adds basic smoke tests for trailsBy submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.