Add LastModifiedTime to Status for ScalableTarget and ScalingPolicy resources

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,14 +1,14 @@
 ack_generate_info:
-  build_date: "2021-09-08T23:45:08Z"
-  build_hash: 394e8294aabf0b221c35f7a5c7bc7e4e43bc6f10
-  go_version: go1.16.4 linux/amd64
+  build_date: "2021-09-10T21:06:37Z"
+  build_hash: a988bddaea3800999e8a548e0e7a4fd44cc00b19
+  go_version: go1.14.14 darwin/amd64
   version: v0.13.2
-api_directory_checksum: 155104e002d9c69b75fd9e85789bf7ee292b866c
+api_directory_checksum: a13caf20935ebb6193efdee1ab377cae33311ad7
 api_version: v1alpha1
 aws_sdk_go_version: v1.37.10
 generator_config_info:
-  file_checksum: 4bf1e52543400e3d52cc745da4c1e2e518e9e1e1
+  file_checksum: 968c7d8481a61c0299fc373cc6d1692a52b55868
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
-  timestamp: 2021-09-08 23:45:13.439536495 +0000 UTC
+  timestamp: 2021-09-10 21:06:47.280077 +0000 UTC

apis/v1alpha1/generator.yaml

@@ -21,10 +21,14 @@ resources:
   ScalableTarget:
     is_adoptable: false
     hooks:
-        sdk_read_many_post_build_request:
-          code: rm.customDescribeScalableTarget(ctx, r, input)
-        delta_pre_compare:
-          code: customSetDefaults(a, b)
+      sdk_create_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
+      sdk_read_many_post_build_request:
+        code: rm.customDescribeScalableTarget(ctx, r, input)
+      delta_pre_compare:
+        code: customSetDefaults(a, b)
+      sdk_update_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
     fields:
       ResourceID:
         is_name: true
@@ -33,8 +37,18 @@ resources:
         from:
           operation: DescribeScalableTargets
           path: ScalableTargets..CreationTime
+      LastModifiedTime:
+        is_read_only: true
+        from:
+          operation: DescribeScalableTargets
+          path: ScalableTargets..CreationTime
   ScalingPolicy:
     is_adoptable: false
+    hooks:
+      sdk_create_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
+      sdk_update_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
     fields:
       ResourceID:
         is_name: true
@@ -45,6 +59,11 @@ resources:
         from:
           operation: DescribeScalingPolicies
           path: ScalingPolicies..CreationTime
+      LastModifiedTime:
+        is_read_only: true
+        from:
+          operation: DescribeScalingPolicies
+          path: ScalingPolicies..CreationTime
 ignore:
     resource_names:
       - ScheduledAction

config/crd/bases/applicationautoscaling.services.k8s.aws_scalabletargets.yaml

@@ -242,6 +242,10 @@ spec:
                 description: The Unix timestamp for when the scalable target was created.
                 format: date-time
                 type: string
+              lastModifiedTime:
+                description: The Unix timestamp for when the scalable target was created.
+                format: date-time
+                type: string
             type: object
         type: object
     served: true

config/crd/bases/applicationautoscaling.services.k8s.aws_scalingpolicies.yaml

@@ -333,6 +333,10 @@ spec:
                 description: The Unix timestamp for when the scaling policy was created.
                 format: date-time
                 type: string
+              lastModifiedTime:
+                description: The Unix timestamp for when the scaling policy was created.
+                format: date-time
+                type: string
             type: object
         type: object
     served: true

generator.yaml

@@ -21,10 +21,14 @@ resources:
   ScalableTarget:
     is_adoptable: false
     hooks:
-        sdk_read_many_post_build_request:
-          code: rm.customDescribeScalableTarget(ctx, r, input)
-        delta_pre_compare:
-          code: customSetDefaults(a, b)
+      sdk_create_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
+      sdk_read_many_post_build_request:
+        code: rm.customDescribeScalableTarget(ctx, r, input)
+      delta_pre_compare:
+        code: customSetDefaults(a, b)
+      sdk_update_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
     fields:
       ResourceID:
         is_name: true
@@ -33,8 +37,18 @@ resources:
         from:
           operation: DescribeScalableTargets
           path: ScalableTargets..CreationTime
+      LastModifiedTime:
+        is_read_only: true
+        from:
+          operation: DescribeScalableTargets
+          path: ScalableTargets..CreationTime
   ScalingPolicy:
     is_adoptable: false
+    hooks:
+      sdk_create_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
+      sdk_update_post_set_output:
+        code: rm.customSetLastModifiedTime(ko)
     fields:
       ResourceID:
         is_name: true
@@ -45,6 +59,11 @@ resources:
         from:
           operation: DescribeScalingPolicies
           path: ScalingPolicies..CreationTime
+      LastModifiedTime:
+        is_read_only: true
+        from:
+          operation: DescribeScalingPolicies
+          path: ScalingPolicies..CreationTime
 ignore:
     resource_names:
       - ScheduledAction

helm/crds/applicationautoscaling.services.k8s.aws_scalabletargets.yaml

@@ -242,6 +242,10 @@ spec:
                 description: The Unix timestamp for when the scalable target was created.
                 format: date-time
                 type: string
+              lastModifiedTime:
+                description: The Unix timestamp for when the scalable target was created.
+                format: date-time
+                type: string
             type: object
         type: object
     served: true

helm/crds/applicationautoscaling.services.k8s.aws_scalingpolicies.yaml

@@ -333,6 +333,10 @@ spec:
                 description: The Unix timestamp for when the scaling policy was created.
                 format: date-time
                 type: string
+              lastModifiedTime:
+                description: The Unix timestamp for when the scaling policy was created.
+                format: date-time
+                type: string
             type: object
         type: object
     served: true

pkg/resource/scalable_target/custom_api.go

@@ -15,7 +15,10 @@ package scalable_target
 
 import (
 	"context"
+	svcapitypes "github.com/aws-controllers-k8s/applicationautoscaling-controller/apis/v1alpha1"
 	svcsdk "github.com/aws/aws-sdk-go/service/applicationautoscaling"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"time"
 )
 
 func (rm *resourceManager) customDescribeScalableTarget(
@@ -31,3 +34,9 @@ func (rm *resourceManager) customDescribeScalableTarget(
 		input.SetResourceIds(resourceIDList)
 	}
 }
+
+// customSetOutputUpdate sets the LastModifiedTime field to the current time post an update
+func (rm *resourceManager) customSetLastModifiedTime(ko *svcapitypes.ScalableTarget) {
+	currentTime := metav1.Time{Time: time.Now().UTC()}
+	ko.Status.LastModifiedTime = &currentTime
+}

pkg/resource/scaling_policy/custom_api.go

@@ -0,0 +1,26 @@
+// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License"). You may
+// not use this file except in compliance with the License. A copy of the
+// License is located at
+//
+//     http://aws.amazon.com/apache2.0/
+//
+// or in the "license" file accompanying this file. This file is distributed
+// on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+// express or implied. See the License for the specific language governing
+// permissions and limitations under the License.
+
+package scaling_policy
+
+import (
+	svcapitypes "github.com/aws-controllers-k8s/applicationautoscaling-controller/apis/v1alpha1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"time"
+)
+
+// customSetOutputUpdate sets the LastModifiedTime field to the current time post an update
+func (rm *resourceManager) customSetLastModifiedTime(ko *svcapitypes.ScalingPolicy) {
+	currentTime := metav1.Time{Time: time.Now().UTC()}
+	ko.Status.LastModifiedTime = &currentTime
+}