Skip to content

Conversation

@eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Nov 18, 2020

Issue #, if available: #31

Description of changes:

In order to have a more robust solution for the internal calls to AWS, the following has been improved:

  • Fix expired security token issue by always use fresh credentials provided by CloudFormation. We need to take into account the fact that lambda execution context are being reused, so ensure new values for credentials and settings are refreshed even when the BaseResource instance is the same from previous call.
  • Use queue to avoid throttling of AWS API calls (specially CloudWatch).
  • Optional use of worker threads for performance reasons.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #30 (5bcf8c3) into master (4594481) will decrease coverage by 0.78%.
The diff coverage is 96.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   99.71%   98.93%   -0.79%     
==========================================
  Files          13       13              
  Lines        1057     1218     +161     
  Branches      185      212      +27     
==========================================
+ Hits         1054     1205     +151     
- Misses          3       13      +10     
Flag Coverage Δ
unittests 98.93% <96.52%> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils.ts 93.93% <91.89%> (-6.07%) ⬇️
src/log-delivery.ts 98.91% <97.11%> (-0.70%) ⬇️
src/resource.ts 98.38% <97.56%> (-0.67%) ⬇️
src/interface.ts 100.00% <100.00%> (ø)
src/metrics.ts 100.00% <100.00%> (ø)
src/proxy.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4594481...5bcf8c3. Read the comment docs.

@eduardomourar eduardomourar marked this pull request as ready for review November 28, 2020 23:08
@eduardomourar eduardomourar changed the title Use worker threads Fix expired security token issue Nov 28, 2020
@eduardomourar eduardomourar merged commit d19c08b into master Dec 2, 2020
@eduardomourar eduardomourar deleted the feature/use-worker-threads branch December 2, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant