Skip to content

Conversation

@kddejong
Copy link
Contributor

@kddejong kddejong commented Apr 3, 2024

Issue #, if available:
#121

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  • Add support for nodejs 20

@kddejong kddejong force-pushed the lifecycle/nodejs/v20 branch from f4fa1fb to 3e87db2 Compare April 3, 2024 19:56
@codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (98fd852) to head (a8b1740).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   98.55%   98.47%   -0.09%     
==========================================
  Files          14       14              
  Lines        1249     1249              
  Branches      209      213       +4     
==========================================
- Hits         1231     1230       -1     
  Misses         17       17              
- Partials        1        2       +1     
Flag Coverage Δ
unittests 98.47% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the lifecycle/nodejs/v20 branch 7 times, most recently from dcd56b3 to fb9bcde Compare April 4, 2024 15:12
@kddejong kddejong force-pushed the lifecycle/nodejs/v20 branch from fb9bcde to a8b1740 Compare April 4, 2024 15:47
Copy link

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kddejong kddejong merged commit 115b7c0 into aws-cloudformation:master Apr 4, 2024
@kddejong kddejong deleted the lifecycle/nodejs/v20 branch April 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants