feat: idempotent fetch #1289
Merged
feat: idempotent fetch #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kellertk
requested changes
Feb 7, 2025
kellertk
reviewed
Feb 7, 2025
test/index.test.ts
Outdated
|
|
||
| mockedSTSClient.on(AssumeRoleWithWebIdentityCommand).resolvesOnce(mocks.outputs.STS_CREDENTIALS); | ||
| await run(); | ||
| expect(core.info).toHaveBeenLastCalledWith('Pre-existing credentials are valid. No need to generate new ones.') |
Member
There was a problem hiding this comment.
We shouldn't expect on log messages if we can help it.
kellertk
reviewed
Feb 7, 2025
kellertk
requested changes
Feb 7, 2025
kellertk
reviewed
Feb 7, 2025
alikulka
approved these changes
Feb 8, 2025
Contributor
alikulka
left a comment
alikulka
left a comment
There was a problem hiding this comment.
Reviewed. Looks good to me!
kellertk
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1288
Description of changes:
Adds a new config option, use-existing-credentials. When set, the action will attempt to re-use existing credentials instead of fetching new credentials. If there are no existing credentials (or if the existing credentials are no longer valid), the action will proceed as normal.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.