Support Concordance plugins #2428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sounds like a good idea 👍 |
Member
Author
|
Just to note, AVA 4 is removing built-in support for React. Ideally we can land this before AVA 4 ships, but no promises. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1861.
I'd like to remove our built-in support of https://github.com/concordancejs/react/, but we'd have to make Concordance configurable.
I think a top-level
pluginsconfiguration will work. You'd provide package names. We'd only support CJS packages for now. We'll publish our own@ava/react(which wraps https://github.com/concordancejs/react/, because we want to configure the colors). If you configureplugins, you won't get the default behavior.To do:
@ava/react