Unnecessary error in extractSource due to not checking for null

[erights]

The line at

ava/lib/serialize-error.js

Line 31 in e9a69dc

if (callSite.file === normalizedFile) {

should be changed to

if (callsite && callSite.file === normalizedFile) {

since the previous line

const callSite = stackUtils.parseLine(line);

may, and sometimes does, initialize callSite to null. Once this is fixed, if the catch at

ava/lib/serialize-error.js

Line 39 in e9a69dc

} catch {}

was there only because of this one error, then this do-nothing catch should be removed.

[novemberborn]

Thanks, that makes sense. I'll try and get this into the next release if nobody else beats me to it.

Looking at the commit history, the earlier logic checked for a falsy value so I assume the catch isn't needed with this guard.

[Fem-Fem]

Hi! Would it be possible for me to work on this?

[novemberborn]

@Fem-Fem that'd be great!

[Fem-Fem]

Thanks! I have a PR here: #2750