Ava does not ignore nested node modules directory

[Siilwyn]

Description

Edit: I found what is causing the issue. Ava does not ignore node_modules directories that are nested but the README seems to state it does:

Directories named fixtures, helpers and node_modules are always ignored.

The project structure is a monorepo with modules/<module-name>/node_modules directories, to make Ava ignore them appending a glob is needed: ava test/*.js !modules/*/node_modules.

Original description for people searching at ENOSPC:

On Linux running Ava in a directory with more than the inotify limit causes Ava to stop with an unhandled error event ENOSPC. It looks like it tries to watch files in node_modules because the error comes from a different file in the node modules directory.

Error Message & Stack Trace

Error: watch <random-file-in-node-modules> ENOSPC
    at _errnoException (util.js:1041:11)
    at FSWatcher.start (fs.js:1382:19)
    at Object.fs.watch (fs.js:1408:11)
    at createFsWatchInstance (/home/siilwyn/myproject/node_modules/chokidar/lib/nodefs-handler.js:37:15)
    at setFsWatchListener (/home/siilwyn/myproject/node_modules/chokidar/lib/nodefs-handler.js:80:15)
    at FSWatcher.NodeFsHandler._watchWithNodeFs (/home/siilwyn/myproject/node_modules/chokidar/lib/nodefs-handler.js:228:14)
    at FSWatcher.NodeFsHandler._handleFile (/home/siilwyn/myproject/node_modules/chokidar/lib/nodefs-handler.js:255:21)
    at FSWatcher.<anonymous> (/home/siilwyn/myproject/node_modules/chokidar/lib/nodefs-handler.js:473:21)
    at FSReqWrap.oncomplete (fs.js:153:5)

Command-Line Arguments

ava test.js --watch

Environment

Node.js v8.4.0
linux 4.4.0-93-generic

[novemberborn]

Thanks for the report @Siilwyn. You're right, AVA should ignore nested node_modules too.

[Siilwyn]

@codeslikejaggars did you PR your change? 🤔

[codeslikejaggars]

Yep, #1574

On Sun, Jan 28, 2018 at 11:52 PM Selwyn ***@***.***> wrote: @codeslikejaggars <https://github.com/codeslikejaggars> did you PR your change? 🤔 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1501 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABfmhVx9z3EWn0tIe8yMziFECz1fzYEuks5tPXi7gaJpZM4PI3Ff> .

-- - Nick

[Siilwyn]

Ah I see, needs a more global refactor. Thank you for your reply @codeslikejaggars.