Skip to content

Add Compression #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 26, 2024
Merged

Add Compression #85

merged 8 commits into from
Nov 26, 2024

Conversation

@SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Nov 26, 2024

  • remove extra Static Resource loader (since compression is in play, we can't really be using Files.size to get exact size)
  • rename resource methods
  • use Executor instead of ThreadFactory
  • Add compression functionality (check on the first call to OutputStream#write whether to compress the full response)

@SentryMan SentryMan added the enhancement New feature or request label Nov 26, 2024
@SentryMan SentryMan added this to the 3.0 milestone Nov 26, 2024
@SentryMan SentryMan requested a review from rbygrave November 26, 2024 18:52
@SentryMan SentryMan self-assigned this Nov 26, 2024
rbygrave
rbygrave previously approved these changes Nov 26, 2024
View reviewed changes
@SentryMan SentryMan merged commit e73397e into avaje:master Nov 26, 2024
4 checks passed
@SentryMan SentryMan deleted the compression branch November 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbygrave rbygrave rbygrave left review comments

Assignees

@SentryMan SentryMan

Labels

enhancement New feature or request

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@SentryMan @rbygrave