Skip to content

Conversation

@rbygrave
Copy link
Contributor

…erator

This way the close() is executed before the catch block rather than after

…erator

This way the close() is executed before the catch block rather than after
@rbygrave rbygrave requested a review from SentryMan November 26, 2024 08:14
@rbygrave rbygrave self-assigned this Nov 26, 2024
@rbygrave rbygrave merged commit 43950bd into master Nov 26, 2024
7 checks passed
@rbygrave rbygrave deleted the feature/autoclose-iterator branch November 26, 2024 08:50
@SentryMan
Copy link
Collaborator

SentryMan commented Nov 26, 2024

@rbygrave
Copy link
Contributor Author

Ah right, thanks.

Yes, ultimately the failing tests were just down to the race conditions in those tests so I started incorrectly there.

Note that if we put it back to try-with-resources its a warning on the empty try block and wants a @SuppressWarnings("EmptyTryBlock") added so I reckon it might be prettier to just leave it like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants