Skip to content

Tidy Context, imports, javadoc, whitespace #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Tidy Context, imports, javadoc, whitespace #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions avaje-jex/src/main/java/io/avaje/jex/Context.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,15 @@ default Context render(String name) {
*/
String protocol();

class Cookie {
/**
* Gets basic-auth credentials from the request, or throws.
*
* <p>Returns a wrapper object containing the Base64 decoded username
* and password from the Authorization header, or null if basic-auth is not properly configured
*/
BasicAuthCredentials basicAuthCredentials();

final class Cookie {
Copy link
Contributor Author

@rbygrave rbygrave Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Cookie should become an interface

Copy link
Collaborator

@SentryMan SentryMan Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it, I'm working on the static file stuff

private static final ZonedDateTime EXPIRED = ZonedDateTime.of(LocalDateTime.of(2000, 1, 1, 0, 0, 0), ZoneId.of("GMT"));
private static final DateTimeFormatter RFC_1123_DATE_TIME = DateTimeFormatter.RFC_1123_DATE_TIME;
private static final String PARAM_SEPARATOR = "; ";
Expand All @@ -375,7 +383,7 @@ class Cookie {
private boolean httpOnly;

private Cookie(String name, String value) {
if (name == null || name.length() == 0) {
if (name == null || name.isEmpty()) {
throw new IllegalArgumentException("name required");
}
this.name = name;
Expand Down Expand Up @@ -492,12 +500,4 @@ public String toString() {
}
}

/**
* Gets basic-auth credentials from the request, or throws.
*
* <p>Returns a wrapper object containing the Base64 decoded username
* and password from the Authorization header, or null if basic-auth is not properly configured
*/
BasicAuthCredentials basicAuthCredentials();

}
3 changes: 0 additions & 3 deletions avaje-jex/src/main/java/io/avaje/jex/DJexConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,10 @@ public JexConfig renderer(String extension, TemplateRender renderer) {

@Override
public ThreadFactory threadFactory() {

if (factory == null) {
factory =
Thread.ofVirtual().name("avaje-jex-http-", 0).factory();
}

return factory;
}

Expand Down Expand Up @@ -130,7 +128,6 @@ public Map<String, TemplateRender> renderers() {

@Override
public SSLContext sslContext() {

return this.sslContext;
}

Expand Down
4 changes: 0 additions & 4 deletions avaje-jex/src/main/java/io/avaje/jex/DefaultRouting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@
import java.util.Map;
import java.util.Set;

import io.avaje.jex.Routing.Entry;
import io.avaje.jex.Routing.Group;
import io.avaje.jex.Routing.HttpService;
import io.avaje.jex.Routing.Type;
import io.avaje.jex.security.Role;

final class DefaultRouting implements Routing {
Expand Down
6 changes: 2 additions & 4 deletions avaje-jex/src/main/java/io/avaje/jex/HttpFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@

import java.io.IOException;

import com.sun.net.httpserver.Filter.Chain;

/**
* A filter used to pre- and post-process incoming requests. Pre-processing occurs before the
* application's exchange handler is invoked, and post-processing occurs after the exchange handler
* returns. Filters are organized in chains, and are associated with {@link Context} instances.
*
* <p>Each {@code HttpFilter} in the chain, invokes the next filter within its own {@link
* #filter(Context, Chain)} implementation. The final {@code HttpFilter} in the chain invokes the
* #filter(Context, FilterChain)} implementation. The final {@code HttpFilter} in the chain invokes the
* applications exchange handler.
*/
@FunctionalInterface
Expand All @@ -26,7 +24,7 @@ public interface HttpFilter {
* <ol>
* <li>Invoke the next filter in the chain, by calling {@link FilterChain#proceed}.
* <li>Terminate the chain of invocation, by <b>not</b> calling {@link
* FilterChain#filter}.
* FilterChain#proceed()}.
* </ol>
* <li>If option 1. above is taken, then when filter() returns all subsequent filters in the
* Chain have been called, and the response headers can be examined or modified.
Expand Down