Skip to content

[SSE] Relax SSE Accept Header Validation #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

[SSE] Relax SSE Accept Header Validation #273

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba8122b
relax sse accept header
SentryMan Jul 11, 2025
cc53610
Update SseHandler.java
SentryMan Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions avaje-jex/src/main/java/io/avaje/jex/http/sse/SseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.io.IOException;
import java.io.UncheckedIOException;
import java.util.Optional;
import java.util.function.Consumer;

import io.avaje.jex.core.Constants;
Expand All @@ -22,9 +23,13 @@ final class SseHandler implements ExchangeHandler {
@Override
public void handle(Context ctx) throws Exception {

if (!TEXT_EVENT_STREAM.equals(ctx.header(Constants.ACCEPT))) {
throw new BadRequestException("SSE Requests must have an 'Accept: text/event-stream' header");
}
Optional.ofNullable(ctx.header(Constants.ACCEPT))
.filter(s -> s.contains(TEXT_EVENT_STREAM))
.orElseThrow(
() ->
new BadRequestException(
"SSE Requests must have an 'Accept: text/event-stream' header"));

final var exchange = ctx.exchange();
final var headers = exchange.getResponseHeaders();
headers.add(Constants.CONTENT_TYPE, TEXT_EVENT_STREAM);
Expand Down