#264 Use AppLog.getLogger() rather than direct System.getLogger() for native-image #265
Conversation
… native-image As per issue #263, when using GraalVM native-image using System.getLogger() directly is problematic for class initialisation. Using AppLog.getLogger() adds that one level of indirection that means we can successfully redirect the log messages to sl4j4-api and onto whatever backend is setup for that.
rbygrave
changed the title
SentryMan
left a comment
SentryMan
left a comment
There was a problem hiding this comment.
When stable values are finalized I'll change it back
My gut says stable values won't "fix" this issue.
I'd tend to think that we'd discuss the pro's and con's and review the decision with what we know at that time. It's kinda not great to try and make a "decision too early" as I see it. |
|
That we'll test it first and confirm whether it's good goes without saying |
Yeah, that wasn't the point I was trying to make. I was trying to say that ... we need to review the decision again at the time. That is, if stable values "works" that actually isn't sufficient for a good decision per se. We'd need to review the pros and cons again at that time - we need to stay open to all options. |
Not what I meant. |
As per issue #264, when using GraalVM native-image using System.getLogger() directly is problematic for class initialisation. Using AppLog.getLogger() adds that one level of indirection that means we can successfully redirect the log messages to sl4j4-api and onto whatever backend is setup for that.