Fix redirect on 404 error handlers #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rbygrave merged 2 commits into avaje:master from SentryMan:redirect

Apr 14, 2025

Collaborator

SentryMan commented Apr 12, 2025

resolves #248


          Fix redirect on 404 error handlers

4dd0c2e

SentryMan added the bug label

SentryMan added this to the 3.1 milestone

SentryMan self-assigned this

SentryMan requested a review from rbygrave

April 12, 2025 17:50

SentryMan enabled auto-merge (squash)

April 12, 2025 17:50

rbygrave reviewed

View reviewed changes

avaje-jex/src/main/java/io/avaje/jex/core/RoutingHandler.java

    
                  if (route == null) {

                    var ctx = new JdkContext(mgr, exchange, uri, Set.of());

                    ctx.setMode(Mode.EXCHANGE);

Contributor

rbygrave Apr 14, 2025

I think we can move this into the constructor. Will merge this in but look to adjust later.

rbygrave approved these changes

View reviewed changes


          Merge branch 'master' into redirect

c86942d

rbygrave disabled auto-merge

April 14, 2025 08:56

rbygrave merged commit d197acb into avaje:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug