Rename configs #519
Closed
Rename configs #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if _, ok := PrecompileAllNativeAddresses[address]; ok { | ||
| panic(fmt.Errorf("precompile address collides with existing native address: %s", address)) | ||
| } | ||
| if address == constants.BlackholeAddr { |
Contributor
There was a problem hiding this comment.
Why was this removed?
Collaborator
Author
There was a problem hiding this comment.
hm I actually moved it to registerer but seems lost in stash. added now. good catch.
Collaborator
There was a problem hiding this comment.
Can we keep it in both places?
ceyonur
commented
Feb 17, 2023
Comment on lines
+55
to
+58
| if address == constants.BlackholeAddr { | ||
| return fmt.Errorf("address %s overlaps with blackhole address", address) | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
moved to here @patrick-ogrady @aaronbuchwald
|
Not against this PR, this is my alternative suggestion #520 happy to follow what others think here to move forward. |
Collaborator
|
Closing in favor of #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented