nits for sync-subnet-evm #539

darioush · 2024-04-25T22:57:52Z

No description provided.

* add parent beacon root checks * add beacon root tests * revert code change * remove comment

* add matrix and race to UTs * remove unnecessary runners * clean script * lazy read bonus blocks * increase timeout * increase frequency * apply fix fow windows * increase timeout * disable fail fast * increase frequency and timeout * use latest * fix coma * better log * fix require * Fix formatting * fix eventually formats * test out new wg * Revert "test out new wg" This reverts commit 5d4a0a8. * check tx indexes after each block accept * mark as flaky * disable blobpool * add IsSubscribed for testing * remove subscribed when return * use atomic bool * attempt to fix flaky indexing test

darioush · 2024-04-25T23:53:24Z

ethclient/corethclient/corethclient.go

 	}
 	if len(msg.Data) > 0 {
-		arg["data"] = hexutil.Bytes(msg.Data)
+		arg["input"] = hexutil.Bytes(msg.Data)


highlighting this

darioush · 2024-04-25T23:59:06Z

params/network_upgrades.go

+		{name: "banffBlockTimestamp", timestamp: c.BanffBlockTimestamp},
+		{name: "cortinaBlockTimestamp", timestamp: c.CortinaBlockTimestamp},
+		{name: "durangoBlockTimestamp", timestamp: c.DurangoBlockTimestamp},
+		{name: "cancunTime", timestamp: c.CancunTime}, // XXX: should this be in ethForks?


see comment, should this be in ethForks? I think this check is missing from subnet-evm

yes I think it fits better in ethforks (as we indirectly activate it via EUpgrade). In Subnet-EVM there is a SetEVMUpgrades that should activate cancun. I put up a draft PR to add Eupgrade and map to Cancun here: https://github.com/ava-labs/subnet-evm/pull/1135/files.

plugin/evm/atomic_syncer_test.go

ceyonur

lgtm

ceyonur · 2024-04-26T09:54:42Z

internal/ethapi/api_test.go

 		randomAccounts = newAccounts(2)
 	)
-	api := NewBlockChainAPI(newTestBackend(t, genBlocks, genesis, dummy.NewFaker(), func(i int, b *core.BlockGen) {
+	api := NewBlockChainAPI(newTestBackend(t, genBlocks, genesis, dummy.NewCoinbaseFaker(), func(i int, b *core.BlockGen) {


coinbasefaker does not do anything in coreth but we can keep it same to reduce diff

ceyonur · 2024-04-26T10:00:52Z

params/network_upgrades.go

+		{name: "banffBlockTimestamp", timestamp: c.BanffBlockTimestamp},
+		{name: "cortinaBlockTimestamp", timestamp: c.CortinaBlockTimestamp},
+		{name: "durangoBlockTimestamp", timestamp: c.DurangoBlockTimestamp},
+		{name: "cancunTime", timestamp: c.CancunTime}, // XXX: should this be in ethForks?


yes I think it fits better in ethforks (as we indirectly activate it via EUpgrade). In Subnet-EVM there is a SetEVMUpgrades that should activate cancun. I put up a draft PR to add Eupgrade and map to Cancun here: https://github.com/ava-labs/subnet-evm/pull/1135/files.

* format as subnet-evm * sync subnet-evm up to c77ba56 * reformat as coreth * fix tests * Tx indexing fix (#1131) * fix unindexor in state sync * fix lint * fix flaky test * Update core/blockchain_test.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * fix reviews * readd delay for index init * Update core/rawdb/accessors_state_sync.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * tx indexer fix: avoids using sleep in test (#1151) * avoids using sleep in test * track all goroutines * trying harder * add some debug information in case of fail * Update core/blockchain.go Signed-off-by: Darioush Jalali <[email protected]> * Update core/blockchain.go Signed-off-by: Darioush Jalali <[email protected]> --------- Signed-off-by: Darioush Jalali <[email protected]> --------- Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Darioush Jalali <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * fix require in test * snapshot: fix race in abort/generate (#1155) * skip pkg cache and update version (#1158) * skip pkg cache and update version * remove goconst linter * ignore tests for goconst * use less blocks to gen * add matrix and race to UTs (#530) * add matrix and race to UTs * remove unnecessary runners * clean script * lazy read bonus blocks * increase timeout * increase frequency * apply fix fow windows * increase timeout * disable fail fast * increase frequency and timeout * use latest * fix coma * better log * fix require * Fix formatting * fix eventually formats * test out new wg * Revert "test out new wg" This reverts commit 5d4a0a8. * check tx indexes after each block accept * mark as flaky * disable blobpool * add IsSubscribed for testing * remove subscribed when return * use atomic bool * attempt to fix flaky indexing test * fix test * return if sub nil * Beacon root check (#529) * add parent beacon root checks * add beacon root tests * revert code change * remove comment * nits for sync-subnet-evm (#539) --------- Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Darioush Jalali <[email protected]> Co-authored-by: Darioush Jalali <[email protected]>

* format as subnet-evm * sync subnet-evm up to c77ba56 * reformat as coreth * fix tests * Tx indexing fix (ava-labs#1131) * fix unindexor in state sync * fix lint * fix flaky test * Update core/blockchain_test.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * fix reviews * readd delay for index init * Update core/rawdb/accessors_state_sync.go Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> * tx indexer fix: avoids using sleep in test (ava-labs#1151) * avoids using sleep in test * track all goroutines * trying harder * add some debug information in case of fail * Update core/blockchain.go Signed-off-by: Darioush Jalali <[email protected]> * Update core/blockchain.go Signed-off-by: Darioush Jalali <[email protected]> --------- Signed-off-by: Darioush Jalali <[email protected]> --------- Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Darioush Jalali <[email protected]> Co-authored-by: Darioush Jalali <[email protected]> * fix require in test * snapshot: fix race in abort/generate (ava-labs#1155) * skip pkg cache and update version (ava-labs#1158) * skip pkg cache and update version * remove goconst linter * ignore tests for goconst * use less blocks to gen * add matrix and race to UTs (ava-labs#530) * add matrix and race to UTs * remove unnecessary runners * clean script * lazy read bonus blocks * increase timeout * increase frequency * apply fix fow windows * increase timeout * disable fail fast * increase frequency and timeout * use latest * fix coma * better log * fix require * Fix formatting * fix eventually formats * test out new wg * Revert "test out new wg" This reverts commit 5d4a0a8. * check tx indexes after each block accept * mark as flaky * disable blobpool * add IsSubscribed for testing * remove subscribed when return * use atomic bool * attempt to fix flaky indexing test * fix test * return if sub nil * Beacon root check (ava-labs#529) * add parent beacon root checks * add beacon root tests * revert code change * remove comment * nits for sync-subnet-evm (ava-labs#539) --------- Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Darioush Jalali <[email protected]> Co-authored-by: Darioush Jalali <[email protected]>

Darioush Jalali and others added 10 commits April 25, 2024 15:57

rebased branch

991f9d3

Beacon root check (#529)

c73ce4b

* add parent beacon root checks * add beacon root tests * revert code change * remove comment

tx index fix

b10f9c7

snapshot: fix race in abort/generate (#1155)

ca4f840

reduce diffs

2ec332c

return if sub nil

f4d8765

use less blocks to gen

9c17dcf

unify scripts

4000a52

updates

4e73f3d

darioush commented Apr 25, 2024

View reviewed changes

darioush commented Apr 26, 2024

View reviewed changes

plugin/evm/atomic_syncer_test.go Show resolved Hide resolved

darioush changed the title ~~format as subnet-evm~~ nits for sync-subnet-evm Apr 26, 2024

darioush marked this pull request as ready for review April 26, 2024 00:02

darioush requested a review from ceyonur as a code owner April 26, 2024 00:02

ceyonur approved these changes Apr 26, 2024

View reviewed changes

update ethForks / config check

70ca30c

ceyonur merged commit dae05ba into sync-subnet-evm Apr 26, 2024

ceyonur deleted the sync-subnet-evm-y branch April 26, 2024 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

nits for sync-subnet-evm #539

nits for sync-subnet-evm #539

Uh oh!

darioush commented Apr 25, 2024

Uh oh!

darioush Apr 25, 2024

Uh oh!

darioush Apr 25, 2024

Uh oh!

ceyonur Apr 26, 2024

Uh oh!

Uh oh!

ceyonur left a comment

Uh oh!

ceyonur Apr 26, 2024

Uh oh!

ceyonur Apr 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nits for sync-subnet-evm #539

nits for sync-subnet-evm #539

Uh oh!

Conversation

darioush commented Apr 25, 2024

Uh oh!

darioush Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

darioush Apr 25, 2024

Choose a reason for hiding this comment

Uh oh!

ceyonur Apr 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ceyonur left a comment

Choose a reason for hiding this comment

Uh oh!

ceyonur Apr 26, 2024

Choose a reason for hiding this comment

Uh oh!

ceyonur Apr 26, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants