Skip to content

Conversation

konobi
Copy link

@konobi konobi commented Aug 12, 2016

…cker instance

COUCHBASE_SERVICES added as an environment variable for the cluster.

Also changes related to allowing the image to be built and tested on a local docker instance.

@tgross
Copy link
Contributor

tgross commented Aug 12, 2016

This LGTM from a technical standpoint.

But I do want to remind @misterbisson that the original reason we wrote the setup.sh to assert the Triton environment in the first place was because we were getting a lot of folks who were running into problems where they'd misconfigured the env file for deploying to Triton. Not sure if this will effectively undo that?

@konobi
Copy link
Author

konobi commented Aug 12, 2016

I don't believe so, i just moved those items behind a check for $TRITON_ACCOUNT. So if there's no TRITON_ACCOUNT, it'll move along as normal, but if it has TRITON_ACCOUNT set, those checks will happen as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants