Fix: leaderboard fills nans
#1432
Merged
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For models that are in the ensemble but have no corresponding entry in model_runs (built from run_history), we fill in NA values to prevent crashing. Why this occurs, I don't know but this should at least prevent total failure when we can still provide other useful information back to the user.
Codecov Report
@@ Coverage Diff @@
## development #1432 +/- ##
===============================================
- Coverage 84.46% 84.44% -0.03%
===============================================
Files 147 147
Lines 11293 11295 +2
Branches 1924 1925 +1
===============================================
- Hits 9539 9538 -1
Misses 1245 1245
- Partials 509 512 +3 |
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
For models that are in the ensemble but have no corresponding entry in model_runs (built from run_history), we fill in NA values to prevent crashing. Why this occurs, I don't know but this should at least prevent total failure when we can still provide other useful information back to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For models that are in the ensemble but have no corresponding entry in model_runs (built from run_history), we fill in NA values to prevent crashing.
Why this occurs, I don't know but this should at least prevent total failure when we can still provide other useful information back to the user.