implement a new attribute allow_string_features
#1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the new text preprocessing. On default it is enabled.
…the new text preprocessing. On default it is enabled.
…the new text preprocessing. On default it is enabled.
Codecov Report
@@ Coverage Diff @@
## development #1420 +/- ##
===============================================
+ Coverage 84.50% 84.57% +0.07%
===============================================
Files 146 146
Lines 11285 11295 +10
Branches 1929 1931 +2
===============================================
+ Hits 9536 9553 +17
+ Misses 1233 1229 -4
+ Partials 516 513 -3 |
|
It all seems okay to me :) Do you want to do the advertisement of the feature in |
i will do this in the next PR. If every thing is okay merge it. |
Louquinze
added a commit
to Louquinze/auto-sklearn
that referenced
this pull request
Mar 16, 2022
Louquinze
added a commit
to Louquinze/auto-sklearn
that referenced
this pull request
Mar 16, 2022
eddiebergman
pushed a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement a new attribute
allow_string_featureswhich en-/disables the new text preprocessing. On default it is enabled.Bascilly the AutoSklearnEstimator gets a new variable
allow_string_featureswhich is True on default. This new varialbe gets passed to the FeatureValidator (feature_validator.py). Here i use if/else statements which check if text features are allowed before assigning the string class. If text_preprocssing is disabledstringandobjectare treated ascategoricalas it was handled priviously.