Skip to content

Fix sparse y test #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Fix sparse y test #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57463cf
Merge pull request #1247 from automl/development
mfeurer Sep 14, 2021
3c7967f
checks y_test for sparse
eddiebergman Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions autosklearn/automl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@ def fit(

# AutoSklearn does not handle sparse y for now
y = convert_if_sparse(y)
y_test = convert_if_sparse(y_test) if y_test is not None else None

# Get the task if it doesn't exist
if task is None:
Expand Down
16 changes: 11 additions & 5 deletions test/test_automl/test_automl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,9 +818,9 @@ def data_input_and_target_types():
pd.DataFrame(data=y_multioutput_regression_ndarray),
]

# [ (X, y, task), ... ]
# [ (X, y, X_test, y_test, task), ... ]
return (
(X, y, task)
(X, y, X, y, task)
for X in xs
for y, task in itertools.chain(
itertools.product(ys_binary, [BINARY_CLASSIFICATION]),
Expand All @@ -832,8 +832,8 @@ def data_input_and_target_types():
)


@pytest.mark.parametrize("X, y, task", data_input_and_target_types())
def test_input_and_target_types(dask_client, X, y, task):
@pytest.mark.parametrize("X, y, X_test, y_test, task", data_input_and_target_types())
def test_input_and_target_types(dask_client, X, y, X_test, y_test, task):

if task in CLASSIFICATION_TASKS:
automl = AutoMLClassifier(
Expand All @@ -849,7 +849,13 @@ def test_input_and_target_types(dask_client, X, y, task):
)
# To save time fitting and only validate the inputs we only return
# the configuration space
automl.fit(X, y, only_return_configuration_space=True)
automl.fit(
X=X,
y=y,
X_test=X_test,
y_test=y_test,
only_return_configuration_space=True
)
assert automl._task == task
assert automl._metric.name == default_metric_for_task[task].name

Expand Down