Skip to content

Conversation

eddiebergman
Copy link
Contributor

Updates the command basedon this comment so it should work for Linux and Windows users. Unix systems should be able to identify that in the full string $PWD:/opt/nb that $PWD is the environment variable. If it's broken on Windows and requires the ${} escape then it seems Windows does not recognize it.

Before as just $PWD:

docker run -it -v $PWD:/opt/nb -p 8888:8888 mfeurer/auto-sklearn:master /bin/bash -c "mkdir -p /opt/nb && jupyter notebook --notebook-dir=/opt/nb --ip='0.0.0.0' --port=8888 --no-browser --allow-root"

After as ${PWD}:

docker run -it -v ${PWD}:/opt/nb -p 8888:8888 mfeurer/auto-sklearn:master /bin/bash -c "mkdir -p /opt/nb && jupyter notebook --notebook-dir=/opt/nb --ip='0.0.0.0' --port=8888 --no-browser --allow-root"

@eddiebergman eddiebergman changed the base branch from master to development September 3, 2021 16:04
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #1235 (904dda7) into development (19a9573) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1235      +/-   ##
===============================================
+ Coverage        88.20%   88.23%   +0.03%     
===============================================
  Files              139      139              
  Lines            11037    11037              
===============================================
+ Hits              9735     9739       +4     
+ Misses            1302     1298       -4     
Impacted Files Coverage Δ
autosklearn/pipeline/implementations/util.py 81.25% <0.00%> (-3.13%) ⬇️
...ine/components/classification/gradient_boosting.py 93.91% <0.00%> (+0.86%) ⬆️
...learn/pipeline/components/regression/libsvm_svr.py 91.46% <0.00%> (+1.21%) ⬆️
...eline/components/feature_preprocessing/fast_ica.py 97.82% <0.00%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a9573...904dda7. Read the comment docs.

@eddiebergman eddiebergman requested a review from mfeurer September 7, 2021 20:16
@mfeurer mfeurer merged commit 2fa3b32 into development Sep 10, 2021
@mfeurer mfeurer deleted the docker_installation_update branch September 10, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants