Skip to content

Conversation

franchuterivera
Copy link
Contributor

Addresses this bug while printing a model:

AttributeError: 'MyDummyClassifier' object has no attribute 'dataset_properties'

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #1114 (a808b61) into development (f518e9a) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1114      +/-   ##
===============================================
+ Coverage        85.46%   85.59%   +0.12%     
===============================================
  Files              137      137              
  Lines            10557    10563       +6     
===============================================
+ Hits              9023     9041      +18     
+ Misses            1534     1522      -12     
Impacted Files Coverage Δ
autosklearn/evaluation/abstract_evaluator.py 90.03% <100.00%> (+1.01%) ⬆️
autosklearn/ensemble_builder.py 77.06% <0.00%> (+0.40%) ⬆️
...ature_preprocessing/select_rates_classification.py 87.32% <0.00%> (+1.40%) ⬆️
autosklearn/util/backend.py 76.15% <0.00%> (+1.42%) ⬆️
...eline/components/feature_preprocessing/fast_ica.py 97.82% <0.00%> (+6.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f518e9a...a808b61. Read the comment docs.

'predictions_ensemble_1_1_0.0.npy')
)

model_path = os.path.join(backend.temporary_directory, '.auto-sklearn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think we should test for the dummy models complying with sklearn, we should not do so here. Could you please create a test in the evaluation module tests?

@mfeurer mfeurer merged commit f6d6be4 into automl:development Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants