Skip to content

Conversation

franchuterivera
Copy link
Contributor

Moving to 'fork' context in the case the number of jobs is equal to 1, and also employing only thread-based computation dask.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1053 (2193c53) into development (4b851c4) will increase coverage by 0.19%.
The diff coverage is 94.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1053      +/-   ##
===============================================
+ Coverage        85.44%   85.64%   +0.19%     
===============================================
  Files              127      129       +2     
  Lines            10177    10323     +146     
===============================================
+ Hits              8696     8841     +145     
- Misses            1481     1482       +1     
Impacted Files Coverage Δ
autosklearn/util/single_thread_client.py 93.18% <93.18%> (ø)
autosklearn/automl.py 84.42% <100.00%> (-0.28%) ⬇️
autosklearn/ensemble_builder.py 76.61% <100.00%> (+0.04%) ⬆️
autosklearn/smbo.py 81.91% <100.00%> (-0.63%) ⬇️
...ature_preprocessing/select_rates_classification.py 84.50% <0.00%> (-2.82%) ⬇️
..._preprocessing/select_percentile_classification.py 86.20% <0.00%> (-1.73%) ⬇️
.../metalearning/metalearning/kNearestDatasets/kND.py 94.04% <0.00%> (ø)
autosklearn/util/hash.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b851c4...2193c53. Read the comment docs.

@franchuterivera franchuterivera marked this pull request as ready for review January 12, 2021 18:45
@franchuterivera
Copy link
Contributor Author

There seems to be a problem with the mirrors of ubuntu causing non-anaconda runs to fail. Examples are working and I will relaunch the runs tomorrow to gain more confidence (but looks like conda-base runs are ok)

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things to go :)

return 'SingleThreadedClient()'

def __del__(self) -> None:
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check automatically check which other methods are implemented by dask using inspection and automatically add these to the single-threaded client and raise a NotImplementedError so that we don't run into any issues in the future?

@mfeurer mfeurer merged commit 05e7263 into automl:development Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants