-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove the __main__ restriction from examples #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1053 +/- ##
===============================================
+ Coverage 85.44% 85.64% +0.19%
===============================================
Files 127 129 +2
Lines 10177 10323 +146
===============================================
+ Hits 8696 8841 +145
- Misses 1481 1482 +1
Continue to review full report at Codecov.
|
There seems to be a problem with the mirrors of ubuntu causing non-anaconda runs to fail. Examples are working and I will relaunch the runs tomorrow to gain more confidence (but looks like conda-base runs are ok) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things to go :)
return 'SingleThreadedClient()' | ||
|
||
def __del__(self) -> None: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check automatically check which other methods are implemented by dask using inspection and automatically add these to the single-threaded client and raise a NotImplementedError so that we don't run into any issues in the future?
Moving to 'fork' context in the case the number of jobs is equal to 1, and also employing only thread-based computation dask.