Skip to content

Conversation

franchuterivera
Copy link
Contributor

Fixes printing ensemble selection messages to stdout by implementing a logging server.

@franchuterivera franchuterivera marked this pull request as ready for review November 16, 2020 12:48
@franchuterivera
Copy link
Contributor Author

As discussed offline, py3.6 is a concern for the logging server (when n_jobs>1). We might look into dropping 3.6 support.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have a too close look yet, but this looks like it's very much going into the right direction. It appears that there are two things that require some more thought and/or work:

  1. the error in Python3.6 right now happens because we pass a logger to the pynisher, which is then passed to a subprocess. The alternative would be to change the pynisher to accept a port and create the logger itself?
  2. I guess the relevant changes need to be done for the evaluation, too?

@mfeurer mfeurer merged commit 168330e into automl:development Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants