-
Notifications
You must be signed in to change notification settings - Fork 1.3k
logging server #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging server #1007
Conversation
As discussed offline, py3.6 is a concern for the logging server (when n_jobs>1). We might look into dropping 3.6 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a too close look yet, but this looks like it's very much going into the right direction. It appears that there are two things that require some more thought and/or work:
- the error in Python3.6 right now happens because we pass a logger to the pynisher, which is then passed to a subprocess. The alternative would be to change the pynisher to accept a port and create the logger itself?
- I guess the relevant changes need to be done for the evaluation, too?
4db6090
to
0c55d5d
Compare
Fixes printing ensemble selection messages to stdout by implementing a logging server.