-
Notifications
You must be signed in to change notification settings - Fork 90
docs(readme): Document createUnsignedAssertion() and improve usage examples #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esarafianou
wants to merge
1
commit into
master
Choose a base branch
from
improve_readme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,10 +6,12 @@ Create SAML assertions. Supports SAML 1.1 and SAML 2.0 tokens. | |
|
|
||
| ### Usage | ||
|
|
||
| #### Signed Assertions | ||
|
|
||
| ```js | ||
| var saml = require('saml').Saml20; // or Saml11 | ||
| const saml = require('saml').Saml20; // or Saml11 | ||
|
|
||
| var options = { | ||
| const options = { | ||
| cert: fs.readFileSync(__dirname + '/test-auth0.pem'), | ||
| key: fs.readFileSync(__dirname + '/test-auth0.key'), | ||
| issuer: 'urn:issuer', | ||
|
|
@@ -23,10 +25,50 @@ var options = { | |
| sessionIndex: '_faed468a-15a0-4668-aed6-3d9c478cc8fa' | ||
| }; | ||
|
|
||
| var signedAssertion = saml.create(options); | ||
| let samlAssertion = saml.create(options) | ||
|
|
||
| // OR with callbacks | ||
|
|
||
| saml.create(options, (err, samlAssertion) => { | ||
| if (err) { throw new Error(err) } | ||
| console.log(samlAssertion) | ||
| }) | ||
| ``` | ||
|
|
||
| All options except of the cert and key are optional. The function can be invoked | ||
| either synchronously or with callbacks, however if the `encryptionCert` option | ||
| has been passed in, the syncronous invocation is not possible | ||
|
|
||
| #### Unsigned Assertions | ||
|
|
||
| ```js | ||
| const saml = require('saml').Saml20; // or Saml11 | ||
|
|
||
| const options = { | ||
| issuer: 'urn:issuer', | ||
| lifetimeInSeconds: 600, | ||
| audiences: 'urn:myapp', | ||
| attributes: { | ||
| 'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress': '[email protected]', | ||
| 'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name': 'Foo Bar' | ||
| }, | ||
| nameIdentifier: 'foo', | ||
| sessionIndex: '_faed468a-15a0-4668-aed6-3d9c478cc8fa' | ||
| }; | ||
|
|
||
| let samlAssertion = saml.createUnsignedAssertion(options) | ||
|
|
||
| // OR with callbacks | ||
|
|
||
| saml.createUnsignedAssertion(options, (err, samlAssertion) => { | ||
| if (err) { throw new Error(err) } | ||
| console.log(samlAssertion) | ||
| }) | ||
| ``` | ||
|
|
||
| Everything except the cert and key is optional. | ||
| All options are optional. The function can be invoked | ||
| either synchronously or with callbacks, however if the `encryptionCert` option | ||
| has been passed in, the syncronous invocation is not possible | ||
|
|
||
| ## Issue Reporting | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synchronous invocation is actually supported unless the
encryptionCertoption has been passed in, at which pointcallbackbecomes required. It's a bit silly but that's how the library has behaved.node-saml/lib/saml20.js
Lines 261 to 263 in 06acc02
I'm ok with the change though.