Skip to content

Conversation

developerkunal
Copy link
Contributor

@developerkunal developerkunal commented Oct 21, 2025

🔧 Changes

  • Add AsyncApprovalNotificationChannels field to Client struct in management/client.go
  • Auto-generate GetAsyncApprovalNotificationChannels getter method in management.gen.go
  • Auto-generate test for GetAsyncApprovalNotificationChannels in management.gen_test.go

This feature allows configuring notification channels for contacting users when their approval is required.

  • Valid values: "guardian-push", "email"
  • Default value: ["guardian-push"]

The field is optional and can be null. To unset values, use a PATCH request with null value.

📚 References

  • Related to CIBA and Risk Assessment Request (RAR) support

🔬 Testing

  • Unit tests auto-generated for the new getter method
  • Manual testing can verify the field is properly serialized/deserialized in Client struct

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (auto-generated)
  • I have added documentation for all new/changed functionality (included in struct comments)

- Add AsyncApprovalNotificationChannels field to Client struct in management/client.go
- Auto-generate GetAsyncApprovalNotificationChannels getter method in management.gen.go
- Auto-generate test for GetAsyncApprovalNotificationChannels in management.gen_test.go

This feature allows configuring notification channels for contacting users when
their approval is required. Valid values: "guardian-push", "email".
Default value: ["guardian-push"]
@developerkunal developerkunal requested a review from a team as a code owner October 21, 2025 08:32
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.29%. Comparing base (af40837) to head (9785341).

Additional details and impacted files
@@           Coverage Diff           @@
##               v1     #635   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files          62       62           
  Lines       12975    12980    +5     
=======================================
+ Hits        12494    12499    +5     
  Misses        363      363           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants