cannot impersonate (sign in as)

[Pyrolistical]

when "sign in as" is used from user management, it triggers the application configured callback:
http://localhost:9000/auth0-callback#access_token=some-access-token&id_token=some-id-token&scope=openid&expires_in=86400&token_type=Bearer
notice, there is no state.

but in auth0.js v9 we have:

auth0.js/src/web-auth/index.js

Lines 180 to 191 in 2ca7ccf

	WebAuth.prototype.validateAuthenticationResponse = function(options, parsedHash, cb) {
	var _this = this;
	var state = parsedHash.state;
	var transaction = this.transactionManager.getStoredTransaction(state);
	var transactionState = options.state || (transaction && transaction.state) || null;
	var transactionStateMatchesState = transactionState === state;
	if (!state || !transactionStateMatchesState) {
	return cb({
	error: 'invalid_token',
	errorDescription: '`state` does not match.'
	});
	}

it always trips "state does not match"

[jimmyn]

I have the same problem. The only solution I've found so far is to use v9.2.3. after this version parseHash method will always check state and if it does not exist return this error.

It is still unclear on how to do impersonation in a new version. I have a suspicion they are going to deprecate this feature.

[Pyrolistical]

Found it @jimmyn v9.2.3...v9.3.1#diff-2f11667c8f671044416e38e4ceb9d7c8R186

You could argue this breaks semver, but you could argue they fixed a bug

[luisrudge]

Hi folks! We're aware of the issue and working in a solution. Thanks for the patience 🎉

[luisrudge]

We're adding a new option so you can enable impersonation again: #689

[Pyrolistical]

The bug fix breaks semver: https://auth0.com/docs/support/how-auth0-versions-software

[luisrudge]

Yes. We're sorry about that. But we're closing an attack vector which is way more important. There will be docs about the trade-offs of using __enableImpersonation and what kind of attacks it leaves your users vulnerable to.

[luisrudge]

hey @Pyrolistical, do you want to test the new version with the flag so we make sure this works in your scenario? I already tested locally, but it'd be good to have an extra pair of hands working on this one! If you want to test it, here's the build file from this PR: https://770-13125982-gh.circle-artifacts.com/0/home/ubuntu/auth0.js/build/auth0.js

you'll need to add the __enableImpersonation flag to your parseHash method, like this:

webAuth.parseHash({__enableImpersonation: true}, function(err, authResult){
  
});

[Pyrolistical]

@luisrudge You are fixing this with an __enableImpersonation flag, but I have a way to fix this that doesn't break semver.

1. When making an impersonation call, add a bypass-state parameter in the hash
2. the bypass-state value is a timestamp on when the impersonation call was made + RS256 signature
3. when auth0.js parseHash see bypass-state, it downloads the well known RS256 public key. it then verifies the RS256 signature of bypass-state and checks the timestamp is within the last 60 seconds

this allows impersonation to just work. the RS256 signature ensures only auth0 can ever set a valid bypass-state parameter. the timestamp in bypass-state prevents CSRF after 60 seconds

[luisrudge]

This is a great idea but, unfortunately, a product decision that I cannot make. You can ask reach out to our support team in https://support.auth0.com and add your suggestion there. I'll personally send this to the appropriate team and we'll see how it goes 🎉

[johnlim]

@luisrudge @Pyrolistical On my end, what I've done is to call checkSession when parseHash (and hence validateAuthenticationResponse) returns error. I'm not sure if that is the original design intent of checkSession but using checkSession negates the need for the additional __enableImpersonation flag. As an example,

        this.auth0.parseHash(function (err, authResult) {
          if (authResult && authResult.accessToken && authResult.idToken) {
            //handle success 
            return
          } else {
            this.auth0.checkSession({
              scope: this.options.auth.scope
            }, function (err, result) {
              if (err || !result || !result.idToken || !result.accessToken) {
                // regular login
                return
              } else {
                //handle success
              }
            }

Would this then nullify the CSRF attack vector associated with __enableImpersonation?

[luisrudge]

checkSession returns the current session in the authorization server (auth0). If impersonation sets a session in the server, then it works.

[johnlim]

@luisrudge Yes it works on my end and so it seems that impersonation does indeed set a session in the server. Thus moving forward, shouldn't that be the default method to use for impersonation rather than setting the __enableImpersonation which then exposes the client to CSRF attacks?

[luisrudge]

I'm not sure we want to recommend people calling checkSession if the parseHash fails. I'll talk with the team internally and see what they think. Thanks for pinging me with this info!