Skip to content

Conversation

@merc1031
Copy link

@merc1031 merc1031 commented Apr 16, 2025

Do not just pick first from search.filters, consider all options, filtering based on git-root and workspaces config

Fix: #2700
Might Fix: #2536

Wrote a few simple unit tests, and tried it by running the client locally. Not sure about which of "[search] filters" vs "workspaces" should be more respected, so i made it so if workspaces = false, regardless of whats in "[search] filters" workspace gets filtered out.

First time looking at atuins code, let me know if this needs any changes.

edit: (from my post here: #2536 (comment))

workspaces = true
[search]
filters = [ "workspace", "directory", "session", "global" ]
^R for the ... time in a git repo any other dir
first workspace directory
second directory session
third session global
fourth global directory
fifth workspace session
sixth directory global

Image

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Do not just pick first from search.filters, consider all options,
filtering based on git-root and workspaces config

atuinsh#2700
@merc1031
Copy link
Author

@ellie Totally understand if you are busy, but is there any codeowner who can look this over and accept or reject?
I have been using a custom compiled binary and it appears to fix the issue that was shown.

Anyway thanks for the amazing tool

@merc1031
Copy link
Author

@ellie @BinaryMuse Just bumping since its been a couple of months. Ive been running this locally since I opened the PR and it appears to fix the issue linked at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [search] filters behaviour inconsistent when used with workspace in filter [Bug]: atuin 18.4 ignores workspaces = true

1 participant