fix(bash): fix loss of the last output line with enter_accept #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
With a single-line prompt, the last line of the output of the previous command is overwritten by the prompt on the enter_accept. In this situation, `tput cuu` receives 0 as the argument, but `tput cuu 0` emits the control sequence `\e[0A`, which moves the cursor above by one line unexpectedly. This is because the parameter 0 for CUU means the default value, 1. In this patch, to avoid moving the cursor when the prompt offset is 0, we check the offset value before running `tput cuu`.
akinomyoga
force-pushed
the
fix-bash-cuu
branch
from
56b8eab to
ccf0c92
Compare
ellie
approved these changes
Dec 28, 2023
Member
|
Failures are unrelated, clippy upgrade by the looks of it. will fix elsewhere, still OK to merge this |
Contributor
Author
|
Thanks! I actually wanted to adjust the blesh-related code, but before that, I wanted to fix this existing issue. I'll submit the adjustments for ble.sh soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a single-line prompt, the last line of the output of the previous command is overwritten by the prompt rendered by
enter_acceptin Bash. I confirmed this behavior in all the terminals I tried, including xterm, lxterminal, terminology, terminator, mlterm, screen.With the single-line prompt,
tput cuureceives 0 as the parameter, buttput cuu 0emits the control sequence\e[0A, which moves the cursor above by one line unexpectedly. This is because the parameter 0 for CUU means the default value, 1.In this PR, to avoid moving the cursor when the prompt offset is 0, we check the offset value before running
tput cuu.