fix(ubuntu/arm*): detect non amd64 ubuntu and handle #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ellie
approved these changes
Jul 30, 2023
ellie
previously approved these changes
Jul 30, 2023
If we're running Ubuntu on non-amd64 we get an install error. As there's no ARM package yet we can offer the user the option to install via cargo rather than install something that won't work.
Contributor
Author
|
@ellie - I've updated this PR to include the org name change that was made. |
ellie
approved these changes
Aug 17, 2023
Member
ellie
left a comment
ellie
left a comment
There was a problem hiding this comment.
Thank you! Sorry it took me so long to circle back on the review 🙃
I'd like to build debs for ARM at some point, seeing as we build binaries for ARM now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're running Ubuntu on non-amd64 we get an install error. As there's no ARM package yet we can offer the user the option to install via cargo rather than install something that won't work.