This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix all compilation errors and warnings for Node.js 12 (V8 7.4). #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
pushed a commit
to meteor/meteor
that referenced
this pull request
May 6, 2019
I'm sure this isn't the best way to fix this problem, but without it the pathwatcher package gets installed without a build/Release directory, which makes the package totally unusable. The unnecessary cleaning happens because the prepublish script always runs after npm install. Very open to any other ways of preserving the build/ directory!
benjamn
force-pushed
the
update-for-node-12
branch
2 times, most recently
from
60d912b to
b83a343
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on the work @abnerlee started in #127.
Meteor can use a fork of the
pathwatcherpackage for now, but it would be great to see these changes released officially sometime soon!Related: atom/watcher#224 (comment)