Skip to content

Conversation

@0xW1sKy
Copy link
Contributor

@0xW1sKy 0xW1sKy commented Mar 26, 2022

method updates:

init

  • updated to check for cloud parameter and trigger separate init process for seamless cloud-relevant configuration.
  • sets api_root parameter for on-prem to allow for single method of building urls within insight.py

all methods

  • updated to use url_joiner(api_root, ) for single pattern across cloud & on-prem
  • added cloud check and NotImplementedError to methods that are not available with Insight Cloud

addition of new methods:

__cloud_init

  • uses __get_workspace_id to assemble api_root path
  • sets default headers to {'Accept': 'application/json'}

__get_workspace_id

  • uses ServiceDeskApi to get InsightCloud workspace Id

@0xW1sKy 0xW1sKy mentioned this pull request Mar 26, 2022
@gonchik gonchik merged commit 04f5506 into atlassian-api:insight-for-jira-module Mar 26, 2022
gonchik added a commit that referenced this pull request Mar 30, 2022
* added simple wrapper

* [Insight] Update to support Cloud (#954)

* Add initial insight cloud capabilities

* Update existing funcitons for cloud api

Co-authored-by: Kyle burk <[email protected]>

Co-authored-by: 0xW1sKy <[email protected]>
Co-authored-by: Kyle burk <[email protected]>
gonchik added a commit that referenced this pull request May 9, 2022
* added simple wrapper

* [Insight] Update to support Cloud (#954)

* Add initial insight cloud capabilities

* Update existing funcitons for cloud api

Co-authored-by: Kyle burk <[email protected]>

* [Insight] Add Insight methods and update docs

* update readme

* resolve pep257 style checks

* Fix linting issues

* [Insight] Adding More Methods (#965)

* [Insight] Add Insight methods and update docs

* update readme

* resolve pep257 style checks

* Fix linting issues

* fix d213

* Attempt at fix for python 3.6 and 3.7 runner

* reduce change and modify order of operations

* focus on krb5 fix

* focus on krb5 fix

* target 3.7

* better targeting

* fi

* test

* test wihtout reinstall

* fix logic error

* test with utils

* fix compare

* pipeline fix for python 3.6 & 3.7

* ugly but functional

Co-authored-by: Gonchik Tsymzhitov <[email protected]>
Co-authored-by: Kyle burk <[email protected]>
gonchik added a commit that referenced this pull request Sep 3, 2022
* added simple wrapper

* [Insight] Update to support Cloud (#954)

* Add initial insight cloud capabilities

* Update existing funcitons for cloud api

Co-authored-by: Kyle burk <[email protected]>

Co-authored-by: 0xW1sKy <[email protected]>
Co-authored-by: Kyle burk <[email protected]>
gonchik added a commit that referenced this pull request Sep 3, 2022
* added simple wrapper

* [Insight] Update to support Cloud (#954)

* Add initial insight cloud capabilities

* Update existing funcitons for cloud api

Co-authored-by: Kyle burk <[email protected]>

* [Insight] Add Insight methods and update docs

* update readme

* resolve pep257 style checks

* Fix linting issues

* [Insight] Adding More Methods (#965)

* [Insight] Add Insight methods and update docs

* update readme

* resolve pep257 style checks

* Fix linting issues

* fix d213

* Attempt at fix for python 3.6 and 3.7 runner

* reduce change and modify order of operations

* focus on krb5 fix

* focus on krb5 fix

* target 3.7

* better targeting

* fi

* test

* test wihtout reinstall

* fix logic error

* test with utils

* fix compare

* pipeline fix for python 3.6 & 3.7

* ugly but functional

Co-authored-by: Gonchik Tsymzhitov <[email protected]>
Co-authored-by: Kyle burk <[email protected]>
gonchik added a commit that referenced this pull request Oct 2, 2022
* added simple wrapper

* [Insight] Update to support Cloud (#954)

* Add initial insight cloud capabilities

* Update existing funcitons for cloud api

Co-authored-by: Kyle burk <[email protected]>

* [Insight] Adding More Methods (#965)

* [Insight] Add Insight methods and update docs

* update readme

* resolve pep257 style checks

* Fix linting issues

Co-authored-by: 0xW1sKy <[email protected]>
Co-authored-by: Kyle burk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants