Skip to content

[RestClient] Cleanup base class and fix init order in derived class #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2020
Merged

[RestClient] Cleanup base class and fix init order in derived class #584

merged 2 commits into from
Sep 9, 2020
+14 −9

Conversation

@Spacetown
Copy link
Contributor

@Spacetown Spacetown commented Sep 8, 2020

Add __init__ to Confluence and move specific code from rest_client.py to this new function.
Change order in __init__ of Bitbucket to prevent errors if __init__of AtlassianRestAPI is dependent from the cloud flag.

@Spacetown Spacetown mentioned this pull request Sep 8, 2020
Closed
gonchik
gonchik reviewed Sep 8, 2020
View reviewed changes
@gonchik gonchik merged commit 09ff44a into atlassian-api:master Sep 9, 2020
@gonchik
Copy link
Member

gonchik commented Sep 9, 2020

Thank you! That's great!

@Spacetown Spacetown deleted the cleanup_rest_client branch September 11, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonchik gonchik gonchik left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Spacetown @gonchik