Skip to content

Update jira.py add_attachment method #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Update jira.py add_attachment method #1126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c62ea4
Update jira.py
laralight Feb 23, 2023
fbffb04
Update jira.py
laralight Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions atlassian/jira.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,12 +1197,24 @@ def add_attachment(self, issue_key, filename):
:param issue_key: str
:param filename: str, name, if file in current directory or full path to file
"""
with open(filename, "rb") as attachment:
return self.add_attachment_object (issue_key, attachment)

def add_attachment_object(self, issue_key, attachment):
"""
Add attachment to Issue
:param issue_key: str
:param attachment: IO object
"""
log.warning("Adding attachment...")
base_url = self.resource_url("issue")
url = "{base_url}/{issue_key}/attachments".format(base_url=base_url, issue_key=issue_key)
with open(filename, "rb") as attachment:
if attachment:
files = {"file": attachment}
return self.post(url, headers=self.no_check_headers, files=files)
else:
log.error("Empty attachment")
return None
return self.post(url, headers=self.no_check_headers, files=files)

def issue_exists(self, issue_key):
original_value = self.advanced_mode
Expand Down